Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Repro for nested function local reassignment issue #30110

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[compiler] Repro for nested function local reassignment issue #30110

merged 2 commits into from
Jun 27, 2024

Conversation

mvitousek
Copy link
Contributor

@mvitousek mvitousek commented Jun 26, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: Additional repro demonstrating a case that still exists after #30106

@mvitousek
[compiler] Repro for nested function local reassignment issue
5bcc119 
Summary: Additional repro demonstrating a case that still exists after #30106

[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 0:09am

@mvitousek mvitousek mentioned this pull request Jun 26, 2024
Merged
josephsavona
josephsavona approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find!

@react-sizebot
Copy link

Comparing: 00775d9...5bcc119

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.10 kB 597.10 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.44 kB 571.44 kB = 101.24 kB 101.24 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 5bcc119

@mvitousek
Update on "[compiler] Repro for nested function local reassignment is…
0eb2cf7 
…sue"

Summary: Additional repro demonstrating a case that still exists after #30106

[ghstack-poisoned]
@mvitousek mvitousek merged commit 0eb2cf7 into gh/mvitousek/0/base Jun 27, 2024
17 of 22 checks passed
mvitousek added a commit that referenced this pull request Jun 27, 2024
@mvitousek
[compiler] Repro for nested function local reassignment issue
1f59d07 
Summary: Additional repro demonstrating a case that still exists after #30106

ghstack-source-id: f03176fd88b29098d0263f86c1a7126e214997e5
Pull Request resolved: #30110
@mvitousek mvitousek deleted the gh/mvitousek/0/head branch June 27, 2024 00:08
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvitousek @react-sizebot @josephsavona @facebook-github-bot